Fix credentials request option written to init.mode instead of init.credentials#171
Merged
Conversation
The credentials value was assigned to init.mode, clobbering the mode option and never reaching fetch(). Assign it to init.credentials. Closes #165 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
|
LGTM. Verified against the source: the diff is exactly the intended one-line change at
No side effects spotted. Ship it. This is an AI-generated review (Claude Code), posted as part of a maintainer-directed review of the test suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the latent bug in #165: the
credentialsrequest option was assigned toinit.modeintest-engine/client/fetching.mjs, clobberingmodeand never reachingfetch(). Now assigned toinit.credentials.No current test sets
credentials, but the test-suite schema defines it, so this prevents the first such test from silently misbehaving.Closes #165
🤖 This PR was generated by an AI agent (Claude Code) under human supervision, as part of a maintainer-directed review of the test suite.